Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in scheduler happening after retrying unsuccessful bindings #37293

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Fix a bug in scheduler happening after retrying unsuccessful bindings #37293

merged 1 commit into from
Nov 23, 2016

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Nov 22, 2016 •
edited by k8s-oncall

Ref #34772

This change is Reviewable

@wojtek-t wojtek-t added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 22, 2016
@wojtek-t
Copy link
Member Author

@mwielgus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2016
@gmarek
Copy link
Contributor

gmarek commented Nov 22, 2016 •
edited

/lgtm

@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2016
@wojtek-t wojtek-t added this to the v1.5 milestone Nov 23, 2016
@wojtek-t wojtek-t changed the title Reduce impact of bug in scheduler of retrying unsuccessful bindings Fix a bug in scheduler happening after retrying unsuccessful bindings Nov 23, 2016
@davidopp davidopp added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 23, 2016
@dchen1107
Copy link
Member

Manually merge this one for 1.5 branch.

@dchen1107 dchen1107 merged commit ead3cc8 into kubernetes:master Nov 23, 2016
This was referenced Nov 29, 2016
Closed
Closed
@wojtek-t wojtek-t mentioned this pull request Dec 2, 2016
Merged
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 2, 2016
@jessfraz jessfraz modified the milestones: v1.4, v1.5 Dec 2, 2016
jessfraz added a commit that referenced this pull request Dec 2, 2016
@jessfraz
Merge pull request #37938 from wojtek-t/automated-cherry-pick-of-#37293-
770bc36 
#37379-upstream-release-1.4

Automated cherry pick of #37293 #37379 upstream release 1.4
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@wojtek-t wojtek-t deleted the fix_scheduler_bug branch December 20, 2016 13:46
@davidopp davidopp mentioned this pull request Mar 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

@davidopp davidopp

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wojtek-t @gmarek @dchen1107 @k8s-cherrypick-bot @jessfraz @davidopp @k8s-github-robot @k8s-ci-robot